CMake error: target dependency added via target_include_directories

[Robert42]

In the example's cmake file, there's a line

target_include_directories(${order}-${exname} PRIVATE Vulkan::Vulkan)

To my knowledge, target_include_directories only allows directory paths and not targets as arguments. I needed to move the Vulkan::Vulkan dependency to target_link_libraries in order to be able to compile the samples

[lhog]

Please confirm you can't compile it now (because I can) and provide your system specs: CMake version, OS, Vulkan SDK version, etc.

[9prady9]

CMake import targets are meant to be used with target_link_libraries unless newer versions added support for using them target_include_directories. Vulkan::Vulkan passed to link libraries call should include the header location just as fine.

[lhog]

See if #18 good enough

[andy-thomason]

Let me know how you get on with the merge...

[FunMiles]

The offending line has been removed in the PR for #21. If it does resolve the issue completely, then this issue should be closed.

[FunMiles]

Now that the PR for #21 has been merged, I think this issue is also addressed. @Robert42, have you tried it ?

[FunMiles]

Without further comment on this issue, should it be closed? @Robert42 can reopen it if there's still an issue for him.

[lhog]

Reopen, in case the issue persists