New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordKey.cc:372:7: warning: suggest explicit braces to avoid ambiguous 'else' #30

Closed

andy5995 opened this issue Nov 18, 2017 · 1 comment

Labels

first-timers-only good first issue help wanted pri: 3 (normal)

Contributor

andy5995 commented Nov 18, 2017 •

edited

The warning needs to be fixed.

WordKey.cc: In member function 'int WordKey::Prefix() const':

WordKey.cc:372:7: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses]

     if(IsDefined(j))

       ^

and this one, in a related file:

WordKeyInfo.cc: In member function 'int WordKeyField::SetString()':

WordKeyInfo.cc:48:18: warning: deprecated conversion from string constant to 'char*' [-Wwrite-strings]

   name.set("Word");

https://github.com/andy5995/htdig/blob/1d0d2f4e17f2bbbfc6b402c1ece51e7e80fe66e2/htword/WordKey.cc#L1

The text was updated successfully, but these errors were encountered:

andy5995 added first-timers-only good first issue help wanted pri: 3 (normal) labels

Contributor Author

andy5995 commented Nov 23, 2017

Closed with 4d0af84

andy5995 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment