Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.io version/upgrade? #653

Open
gardwired opened this issue Jan 2, 2018 · 1 comment
Open

socket.io version/upgrade? #653

gardwired opened this issue Jan 2, 2018 · 1 comment

Comments

@gardwired
Copy link

a couple of questions:

  1. is there any chance that socket.io that is packaged under simplewebrtc will be upgraded? we are running socket.io 2.0.4 for a new project and are having issues with our bundle using newer 2.x for simplewebrtc and are getting 1000s of xhr polls. fixed it by removing our new socket but would be nice to have a single socket version.

  2. is there any incompatibility with using 2.x socket.io with simplewebrtc? if not, is there a config setting to set the version?

  3. any suggestions about how to package this with two different versions of socket.io with webpack? would prefer not to have separate bundles.

thanks again for the hard work. really like simplewebrtc.

@tgabi333
Copy link
Collaborator

tgabi333 commented Jan 3, 2018

Socketio upgrade is a BC in simplewebrtc and signalmaster.

You can pass your own connection class in the constructor (src/socketioclass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants