Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing To Do list: part 1 #3

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Testing To Do list: part 1 #3

wants to merge 13 commits into from

Conversation

mohamedSabry0
Copy link
Collaborator

In this PR, we wrote unit tests for the To Do list application. We tested functions responsible for adding and deleting list items. We also included a coverage file that shows the current test coverage for the project with the --coverage flag.

Copy link

@HAMMAS-SALEEM HAMMAS-SALEEM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢

success
Hey @andym80, @mohamedSabry0 👋

Great work on implementing the tests. Your project is complete. There is nothing else to say about your project. 👍
Go ahead and merge it. 💪

Highlights 🥇

✔️ Following Github Flow
✔️ Following Linters
✔️ Tests are passing

[Optional]

[Optional]

  • You are using jest for your branch name which is not so descriptive. Branch name tells you what is happening in this branch and jest is not telling which part of your app you are testing. You can use feature/testing-todolist-part1. This also shows your professionalism with your work. 😊
    All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants