Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isContinuation is incorrect for results spanning more than 2 lines when using searchPageText #11

Open
rybon opened this issue Sep 18, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@rybon
Copy link

rybon commented Sep 18, 2022

isContinuation correctly is set to true for the first rectangle when a result spans 2 lines. However, when a result spans 3 lines, one would expect the second rectangle to be set to isContinuation: true as well, with only the last rectangle (representing the 3rd line) be set to isContinuation: false. This issue means the rectangles representing the search results end up grouped together incorrectly (the 3rd line ends up as a discrete search result).

@andytango
Copy link
Owner

Hey @rybon, could you please provide repro steps, including:

  • the example file
  • the search query you used
  • the page number that this behaviour is observed on?

Thanks! 😀

@andytango andytango self-assigned this Sep 18, 2022
@andytango andytango added the bug Something isn't working label Sep 18, 2022
@rybon
Copy link
Author

rybon commented Sep 29, 2022

I am using another WASM build now. Apparently this build does not output continuation information. I'll try to recompile with this output (requires some tweaks in C) to see if this problem goes away in newer versions of mupdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants