New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby coverage file path default #17
Comments
The JSONFormatter outputs to |
Why not supporting the default formatter which is also json? |
I was not aware of the PRs are welcome if you'd like to add support for using that though. If you decide to go that route, it probably makes sense to make the option configurable so anyone currently using the JSONFormatter can continue to do so. |
@andythigpen Will try :) any idea about the error mentioned on top ? |
The error is due to the difference in formats mentioned above. The ruby module expects there to be a |
@andythigpen i get the same error using the coverage.json from the json formatter. |
Can you provide a small sample project that demonstrates the issue? Unfortunately I'm not able to reproduce it. |
I ran into a similar issue with reading the output from the JSON formatter myself. It turns out there are two gems that generate JSON output for simplecov ( @andythigpen Your integration test pointed me to the |
Seems the default cov file generated by simplecov is
coverage/.resultset.json
Tried with https://github.com/vicentllongo/simplecov-json that generate nvim-coverage current ruby cov path, but I get a error when loading the file. I also tried with renaming the default resultset to coverage and get the same error upon load.
nvim-coverage/lua/coverage/config.lua
Line 102 in 866008d
the error:
The text was updated successfully, but these errors were encountered: