Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I Really Don't Know #4

Closed
desagas opened this issue Jan 8, 2021 · 0 comments
Closed

I Really Don't Know #4

desagas opened this issue Jan 8, 2021 · 0 comments

Comments

@desagas
Copy link

desagas commented Jan 8, 2021

Hello, you mentioned me on the bug report for MC-121772, and I just added new code that they could very easily implement. I mean, it is not like the xoffset is used for anything at all in regards to scrollCallbacks, so, why not implement it.

I was looking at your code, and tried to make a script to pull the callbacks, but could not figure it out in forge.. Plus, in both versions, the actual definition of the scrollCallback is Private, which means I can not override it, not matter how hard I try to. So, if minecraft won't hot fix it, I am hoping forge will take my PR once I get it up to them. Fingers crossed.

Great mod!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants