New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How many iterations to do? #20
Comments
Hey @mishrsud. Thanks for your feedback! :) Yeah, to be perfectly honest I am not completely sure about this yet either. I think we still need more experience in using leakage for memory leak testing. The lib is not even one month old, so for me it is hard to tell as well. My experience so far: The heap snapshotting/diffing works quite precisely, except for the first snapshot (still got to debug why) and it triggers a full GC before snapshotting, providing almost noise-free results. I am quite confident that even few iterations work well for simple cases. I would assume it works for more complex tests just as fine, since a heap snapshot is a heap snapshot, no matter how much heap operations have been done and the test fails if the heap size increased, regardless of what made it grow. Please share your experiences any time! :) |
Update: The new version that is about to be released comes with a slightly changed API. In future you won't have to pass the So I will close the issue as soon as the new version is released. If you feel that this issue is still important, share your thoughts any time 😉 |
Leakage 0.3 is out and the new API will make this topic less interesting. It is also mentioned in the readme's FAQ. |
Hello Maintainers,
Please accept a hat-tip, love what I see thus far in the project. I have a question/comment regarding the wording here:
From past experience, generally profiling tests encourage having a sufficiently large iteration count, so this suggestion sounds a tad counter-intuitive. A lower iteration count may produce false-positives (unless there is a glaringly obvious leak that is caught easily). I believe this phrase should be removed.
What are your thoughts?
The text was updated successfully, but these errors were encountered: