Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Failed to construct 'Worker' #5

Closed
JuliaCBrown opened this issue Aug 9, 2019 · 3 comments
Closed

Uncaught TypeError: Failed to construct 'Worker' #5

JuliaCBrown opened this issue Aug 9, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@JuliaCBrown
Copy link

Hey! I'm getting this same issue from the parent library: GoogleChromeLabs#2

It looks like you modified the area that had the fix in this commit. 2d122f0

Could the fix be added back in?

@andywer
Copy link
Owner

andywer commented Sep 5, 2019

Hey @JuliaCBrown, thanks for pointing that out!

I am terribly sorry for the delay, I just saw your issue. For some reason I wasn't automatically watching the repository...

The issue in the parent repo was fixed by that commit: GoogleChromeLabs@9178a29

I don't see how the commit solved the presence of the unsupported option prop, though. I think I removed the lines of code in question for a good reason, can't tell which one anymore.

Any ideas? Don't have the time to debug in detail right now, unfortunately.

Maybe you gave up on that issue by now - I hope not 😉
If you found another solution in the meantime, let me know!

@andywer andywer added the help wanted Extra attention is needed label Sep 5, 2019
@JuliaCBrown
Copy link
Author

Sorry for the delay myself! I was on vacation for a while and I'm finally getting caught back up with all my emails.

I'm not totally sure but I think maybe GoogleChromeLabs@9178a29#diff-1fdf421c05c1140f6d71444ea2b27638R55 this part is the relevant part? Where it is saving the type prop and then passing that along on lines 75/77.
I've not actually been looking into this recently because adding in worker pools is a non-critical tech debt item, but if this is the issue then I'd love to get back into it.

@andywer
Copy link
Owner

andywer commented Sep 30, 2020

I think this issue might already be fixed. Feel free to re-open or leave a comment here if I am wrong 😉

@andywer andywer closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants