Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message.TimeToLive should be an int #8

Closed
gldraphael opened this issue Aug 16, 2017 · 1 comment
Closed

Message.TimeToLive should be an int #8

gldraphael opened this issue Aug 16, 2017 · 1 comment

Comments

@gldraphael
Copy link

The TimeToLive property is defined as a byte.

It must, however, be an int. The max value that can be represented by a byte is 255 seconds which is insufficient to hold the max time_to_live value which is 2,419,200 seconds (28 days). Source
@gldraphael gldraphael changed the title Message.TimeToLive should be an int Message.TimeToLive should be an int Aug 16, 2017
angelobelchior added a commit that referenced this issue Aug 17, 2017
@angelobelchior
Message.TimeToLive should be an int #8
6b5679a
@angelobelchior
Copy link
Owner

Fixed! Thank you! :)

https://www.nuget.org/packages/FCM.Net/1.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@angelobelchior @gldraphael