Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Document Hover #12

Closed
3 tasks done
angelozerr opened this issue Jun 29, 2018 · 6 comments
Closed
3 tasks done

[Request] Document Hover #12

angelozerr opened this issue Jun 29, 2018 · 6 comments
Assignees
@angelozerr
Labels
enhancement New feature or request hover
Milestone
v0.5.0

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Jun 29, 2018 •
edited by NikolasKomonen

Support hover over

  • Tag
  • Attributes
  • Values
@angelozerr angelozerr self-assigned this Jun 29, 2018
angelozerr added a commit that referenced this issue Jul 5, 2018
@angelozerr
Support for hover based on element XSD (see #12)
d6fd339
@fbricon fbricon added the enhancement New feature or request label Jul 9, 2018
angelozerr added a commit that referenced this issue Jul 24, 2018
@angelozerr
Activate hover capabilities (supported by xsd) (see #12)
9adaebc
@angelozerr
Copy link
Contributor Author

Hover starts working (with xml schema):

image

@angelozerr
Copy link
Contributor Author

We need to add tests for this hover support

angelozerr added a commit that referenced this issue Aug 7, 2018
@angelozerr
Add hover test (see #12)
d23614b
angelozerr added a commit that referenced this issue Aug 10, 2018
@angelozerr
Prepare hover for attribuet name/value (see #12)
bd4e983
@angelozerr
Copy link
Contributor Author

Test was added, today only tag hover is supported, we need to support attribute name and value hover.

@fbricon
Copy link
Contributor

fbricon commented Sep 26, 2018

So hover on attribute now works. Attribute enum values show the attribute doc though.

@angelozerr
Copy link
Contributor Author

Indeed, I must implement it. My idea is tro try to search doc for value, if not found, I display doc for attribute name. Are you OK?

@fbricon
Copy link
Contributor

fbricon commented Sep 28, 2018

sounds good

@fbricon fbricon added this to the v0.0.3 milestone Nov 3, 2018
@fbricon fbricon added the hover label Nov 15, 2018
@fbricon fbricon modified the milestones: v0.0.3, v0.0.4 Nov 15, 2018
@NikolasKomonen NikolasKomonen modified the milestones: v0.4.0, v0.5.0 Mar 1, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 28, 2019
@NikolasKomonen
Hover for attribuite values using XSD
a959cb7 
Fixes eclipse#12

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Mar 29, 2019
@NikolasKomonen
Hover for attribuite values using XSD
9ab7adc 
Fixes eclipse#12

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@NikolasKomonen NikolasKomonen mentioned this issue Mar 29, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 1, 2019
@NikolasKomonen
Hover for attribute values using XSD
6f327ea 
Fixes eclipse#12

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 3, 2019
@NikolasKomonen
Hover for attribute values using XSD
b9f38db 
Fixes eclipse#12

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 3, 2019
@NikolasKomonen
Hover for attribute values using XSD
b89eef7 
Fixes eclipse#12

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 3, 2019
@NikolasKomonen
Hover for attribute values using XSD
cdd5c09 
Fixes eclipse#12

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 3, 2019
@NikolasKomonen
Hover for attribute values using XSD
64b5ec1 
Fixes eclipse#12
Fixes eclipse#339

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
fbricon pushed a commit that referenced this issue Apr 3, 2019
@NikolasKomonen @fbricon
Hover for attribute values using XSD
ffc3f0f 
Fixes #12
Fixes #339

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
enhancement New feature or request hover
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
3 participants
@fbricon @angelozerr @NikolasKomonen