Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File association should support relative path for systemId #142

Closed
fbricon opened this issue Sep 24, 2018 · 5 comments
Closed

File association should support relative path for systemId #142

fbricon opened this issue Sep 24, 2018 · 5 comments
Labels
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 24, 2018

right now, trying to validate the examples from IBM's XML language server by associating files like:

"xml.fileAssociations": [{
    "systemId": "file_association/invoice.xsd",
    "pattern": "**/file_association/invoice_*.xml"
},

has no effect. I tried using an absolute path for systemId but didn't work either (tried on a Mac)

@fbricon
Copy link
Contributor Author

fbricon commented Sep 24, 2018

so absolute path actually works but I had to restart the server to get it working.

Also, after using a relative path and restarting the server, I get a bunch of errors like:

schema_reference.4: Failed to read schema document 'file_association/invoice.xsd', because 1) could not find the document; 2) the document could not be read; 3) the root element of the document is not xsd:schema.

@angelozerr
Copy link
Contributor

@fbricon please tell me if it works for you.

@fbricon
Copy link
Contributor Author

fbricon commented Sep 26, 2018

Works for **/file_association/invoice_*.xml. Not for */file_association/invoice_*.xml (the syntax in IBM's example). Not sure if it's a big deal

@angelozerr
Copy link
Contributor

The IBM Language Server uses regexp to do that. In my case I'm using glob pathmatcher. I'm not sure if we should support IBM Language Server syntax too.

@fbricon
Copy link
Contributor Author

fbricon commented Sep 26, 2018

It's probably fine as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants