Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion for xsi attributes #163

Closed
angelozerr opened this issue Oct 15, 2018 · 10 comments
Closed

Completion for xsi attributes #163

angelozerr opened this issue Oct 15, 2018 · 10 comments
Assignees
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request XSD
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Oct 15, 2018

Add completion for xsi attributes:

  • schemaLocation
  • noNamespaceSchemaLocation
  • nil?

See https://www.w3.org/TR/xmlschema-1/#d0e3067

@angelozerr angelozerr added the completion This issue or enhancement is related to completion support label Oct 15, 2018
@angelozerr angelozerr changed the title Completion on xsi attributes Completion for xsi attributes Oct 15, 2018
@NikolasKomonen
Copy link
Contributor

@angelozerr Think I can work on this?

@angelozerr
Copy link
Contributor Author

yes sure!

@NikolasKomonen
Copy link
Contributor

@angelozerr Would you recommend I create a new IXMLExtension implementation for this issue. Or should I put it into an existing class like ContentModelPlugin or XMLReferencesPlugin?

@angelozerr
Copy link
Contributor Author

ContentModelCompletionParticipant is good I think.

@NikolasKomonen
Copy link
Contributor

NikolasKomonen commented Oct 30, 2018

@angelozerr Should the completion items be static or read from https://www.w3.org/2001/XMLSchema-instance ?

@angelozerr
Copy link
Contributor Author

read from https://www.w3.org/2001/XMLSchema-instance

You mean using an XML Schema? If it exists an XML Schema for XMLSchema-instance it should be cool to use it, otherwise we need to hard coded that (I think we should do that, but please check that it exists a XMLSchema-instance XML Schema).

@NikolasKomonen
Copy link
Contributor

NikolasKomonen commented Oct 31, 2018

@angelozerr I found that https://www.w3.org/2001/XMLSchema-instance == https://www.w3.org/2001/XMLSchema-instance.xsd . If you use a web browser to view the page source it has the xsd.

Im trying to use the loader here with one of the above URI's but it doesnt seem to work.

Is this right place to be doing this, do you think it will take a lot more work to get it working?

@angelozerr
Copy link
Contributor Author

An interesting topic about this XMLSchema is https://stackoverflow.com/questions/17094247/where-is-the-xsd-file-for-http-www-w3-org-2001-xmlschema-instance

You can view source of this XML Schema with Chrome: view-source:https://www.w3.org/2001/XMLSchema-instance but it says

This schema should never be used as such: the XML Schema Recommendation forbids the declaration of attributes in this namespace

So I think we shouldhard coding this completion and perhaps validation too?

@NikolasKomonen
Copy link
Contributor

@angelozerr I agree, hard coding should be good. I'll work on completion for now.

@angelozerr
Copy link
Contributor Author

I'll work on completion for now.

Very cool! Thanks!

@fbricon fbricon added this to the v0.0.3 milestone Nov 3, 2018
@angelozerr angelozerr added XSD enhancement New feature or request labels Nov 3, 2018
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 6, 2018
Fixes eclipse#163

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 6, 2018
Fixes eclipse#163

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 6, 2018
Fixes eclipse#163

Signed-off-by: Nikolas <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 7, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 13, 2018
Fixes eclipse#163

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion This issue or enhancement is related to completion support enhancement New feature or request XSD
Projects
None yet
Development

No branches or pull requests

3 participants