Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate XML Schema #190

Closed
angelozerr opened this issue Nov 2, 2018 · 11 comments
Closed

Validate XML Schema #190

angelozerr opened this issue Nov 2, 2018 · 11 comments
Assignees
Labels
enhancement New feature or request validation XSD
Milestone

Comments

@angelozerr
Copy link
Contributor

It should be cool to validate XML Schema types. takes a sample like this:

<?xml version="1.0" encoding="UTF-8"?>
<xs:schema xmlns:xs="http://www.w3.org/2001/XMLSchema">

	<xs:element name="person">
		<xs:complexType>
			<xs:sequence>
				<xs:element name="name" type="XXXXXX" />
				<xs:element name="prenom" type="xs:string" />
				<xs:element name="date_naissance" type="xs:date" />
			</xs:sequence>
		</xs:complexType>
	</xs:element>
</xs:schema>

Eclipse WTP XML Editor display those following errors:

image

@angelozerr angelozerr added enhancement New feature or request XSD labels Nov 2, 2018
@angelozerr angelozerr self-assigned this Nov 2, 2018
@fbricon fbricon added this to the v0.0.3 milestone Nov 3, 2018
@angelozerr
Copy link
Contributor Author

@fbricon this issue starts working:

image

I'm writing tests and after I will able to commit my work, can I do that or you prefer creating release before?

@fbricon
Copy link
Contributor

fbricon commented Nov 5, 2018

Open a PR, that way we can test it and if safe to merge before the release, then we'll do that

@angelozerr
Copy link
Contributor Author

When you think you could do the release?

@fbricon
Copy link
Contributor

fbricon commented Nov 5, 2018

Depends on @NikolasKomonen. Hopefully later today or tomorrow, once everything is done. See https://waffle.io/redhat-developer/vscode-xml?milestone=v0.0.2,0.2.0

@angelozerr
Copy link
Contributor Author

@fbricon I have commited my work but XSD validator is not enable .

If you want to play with it, you must just uncomment https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/xsd/participants/diagnostics/XSDDiagnosticsParticipant.java#L38

@fbricon
Copy link
Contributor

fbricon commented Nov 5, 2018

I'd have preferred you opened a PR. That commit contains significant changes, even if it's not enabled by default

@angelozerr
Copy link
Contributor Author

I'd have preferred you opened a PR. That commit contains significant changes, even if it's not enabled by default

DO you want I revert my work?

@angelozerr
Copy link
Contributor Author

I'd have preferred you opened a PR.

Sorry @fbricon I will do it next time -(

@angelozerr
Copy link
Contributor Author

@fbricon I'm writting test for this feature. Do you think I can enable it once test will be finished or you prefer waiting for creating release 0.2 before I activate it.

@fbricon
Copy link
Contributor

fbricon commented Nov 6, 2018

go ahead. If it breaks something, we'll revert before releasing

@angelozerr
Copy link
Contributor Author

go ahead. If it breaks something, we'll revert before releasing

After writing tests, I have seen that there is some trouble, so I prefer not enabling the XSD validation. I must study more Xerces source code to understand the problem. In other words you can create release now if you wish.

@fbricon fbricon modified the milestones: v0.0.3, v0.0.4 Nov 15, 2018
@NikolasKomonen NikolasKomonen removed this from the v0.4.0 milestone Jan 30, 2019
@angelozerr angelozerr added this to the v0.7.0 milestone May 23, 2019
angelozerr pushed a commit that referenced this issue May 24, 2019
Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue May 24, 2019
Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue May 24, 2019
Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue May 28, 2019
Signed-off-by: azerr <azerr@redhat.com>
NikolasKomonen pushed a commit that referenced this issue May 29, 2019
Signed-off-by: azerr <azerr@redhat.com>
@fbricon fbricon closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validation XSD
Projects
None yet
Development

No branches or pull requests

3 participants