Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rootUri for XML catalog configuration #206

Closed
angelozerr opened this issue Nov 8, 2018 · 8 comments
Closed

Support rootUri for XML catalog configuration #206

angelozerr opened this issue Nov 8, 2018 · 8 comments
Assignees
Labels
bug Something isn't working catalog
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Nov 8, 2018

When catalog path is relative:,

{
    "xml.catalogs": [
        "./catalog.xml"
    ]
}

It is not loaded. It should use rootUri workspace.

@angelozerr angelozerr added bug Something isn't working catalog labels Nov 8, 2018
@angelozerr angelozerr self-assigned this Nov 8, 2018
@angelozerr angelozerr added this to the v0.0.2 milestone Nov 8, 2018
@angelozerr
Copy link
Contributor Author

This issue should be fixed. I must write a test yet.

@fbricon
Copy link
Contributor

fbricon commented Nov 8, 2018

@angelozerr build is broken!

@angelozerr
Copy link
Contributor Author

I cannot reproduce the problem wuth my Windows OS -(

@angelozerr
Copy link
Contributor Author

@fbricon build is fixed but I have disable the fix of this issue. I don't understand why it doesn't work on Travis. In my case on Windows OS, all tests passed.

@fbricon
Copy link
Contributor

fbricon commented Nov 8, 2018

ok thanks. Please use PRs until we complete the release.

@fbricon fbricon modified the milestones: v0.0.2, v0.0.3 Nov 8, 2018
@angelozerr
Copy link
Contributor Author

ok thanks. Please use PRs until we complete the release.

Yes sure! I was too confident. I promise you, I will wait for the release before pushing to master (or create a PR).

@angelozerr
Copy link
Contributor Author

I have reactivated and test pass now.

@ralfhandl
Copy link

@angelozerr Thanks, works like a charm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working catalog
Projects
None yet
Development

No branches or pull requests

3 participants