Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add sibling element when completion items is filled with grammar #211

Closed
angelozerr opened this issue Nov 9, 2018 · 2 comments
Closed

Don't add sibling element when completion items is filled with grammar #211

angelozerr opened this issue Nov 9, 2018 · 2 comments
Assignees
@angelozerr
Labels
bug Something isn't working CM Extension Content Model extension (XML Schema & DTD) completion This issue or enhancement is related to completion support
Milestone
v0.3.0

Comments

@angelozerr
Copy link
Contributor

In some case (I have just reproduce it once), there is duplicate element (element coming from sibling and element coming from grammar:

image

See #210

This logic should work, but it fails in some case. I cannot reproduce it every time, but to be sure to avoid having this trouble, we must exectute completion of content model (from grammar) before sibling strategies and check we have NOT element coming from grammar to process sibling strategy.
@angelozerr angelozerr added bug Something isn't working CM Extension Content Model extension (XML Schema & DTD) completion This issue or enhancement is related to completion support labels Nov 9, 2018
@angelozerr angelozerr added this to the v0.0.3 milestone Nov 9, 2018
@angelozerr angelozerr self-assigned this Nov 9, 2018
@angelozerr
Copy link
Contributor Author

@ralfhandl duplicate element should be fixed.

@ralfhandl
Copy link

+1: works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working CM Extension Content Model extension (XML Schema & DTD) completion This issue or enhancement is related to completion support
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@ralfhandl @angelozerr