Adjust range error for internal DTD declaration

[angelozerr]

When internal DTD declaration is done with bad syntax, error is not well adjusted:

To fix this issue we need that XMLDocument is able to parse DTD declaration (here <!Element).

UPDATE
Implemented Error Codes:

Refer here for more info on each code.

• AttNameRequiredInAttDef,
• AttTypeRequiredInAttDef,
• AttlistDeclUnterminated,
• ElementDeclUnterminated,
• EntityDeclUnterminated,
• ExternalIDorPublicIDRequired,
• IDInvalidWithNamespaces,
• IDREFInvalidWithNamespaces,
• IDREFSInvalid,
• LessthanInAttValue,
• MSG_ATTRIBUTE_NOT_DECLARED,
• MSG_ATTRIBUTE_VALUE_NOT_IN_LIST,
• MSG_CONTENT_INCOMPLETE,
• MSG_CONTENT_INVALID,
• MSG_ELEMENT_NOT_DECLARED,
• MSG_ELEMENT_TYPE_REQUIRED_IN_ATTLISTDECL,
• MSG_ELEMENT_TYPE_REQUIRED_IN_ELEMENTDECL,
• MSG_ELEMENT_WITH_ID_REQUIRED,
• MSG_ENTITY_NAME_REQUIRED_IN_ENTITYDECL,
• MSG_FIXED_ATTVALUE_INVALID,
• MSG_MARKUP_NOT_RECOGNIZED_IN_DTD,
• MSG_NOTATION_NAME_REQUIRED_IN_NOTATIONDECL,
• MSG_OPEN_PAREN_OR_ELEMENT_TYPE_REQUIRED_IN_CHILDREN,
• MSG_REQUIRED_ATTRIBUTE_NOT_SPECIFIED,
• MSG_SPACE_REQUIRED_AFTER_NOTATION_NAME_IN_NOTATIONDECL,
• NotationDeclUnterminated,
• OpenQuoteExpected,
• OpenQuoteMissingInDecl,
• QuoteRequiredInPublicID,
• QuoteRequiredInSystemID
• SpaceRequiredAfterSYSTEM,

[fbricon]

@angelozerr what's the status on this one?

[angelozerr]

It starts working with malformed <!ELEMENT. I need to support malformed <!ATTRLIST and <!ENTITY too.

But I think I'll find more unsupported errors. My proposition is to support malformed <!ATTRLIST and <!ENTITY and close this issue for now. We will open a new one if we find another unsupported error.

[fbricon]

Given this snippet:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE Folks [
	<!ELEMENT Folks (Person*)>
	<!ELEMENT Person (Name,Email?)>
	<!ATTLIST Person Pin ID #REQUIRED>
	<!ATTLIST Person Friend IDREF #IMPLIED>
	<!ATTLIST Person Likes IDREFS #IMPLIED>
	<!ELEMENT Name (#PCDATA)>
	<!ELEMENT Email (#PCDATA)>
	]>
<Folks>
	<Person Pin="id1">
        <Name>Fred</Name>
        <Email>frfr</Email>
    </Person>
    <Person Pin="id2" Friend="" Likes="id1">
        <Name>Bob</Name>
    </Person>
</Folks>

The diagnostic on Likes has the wrong range:

Attribute value "" of type IDREF must be an NCName when namespaces are enabled.

[fbricon]

Same snippet, but with some random value in Friend:

{
	"resource": "/Users/fbricon/Downloads/sample-resources/some.xml",
	"owner": "_generated_diagnostic_collection_name_#0",
	"code": "MSG_ELEMENT_WITH_ID_REQUIRED",
	"severity": 8,
	"message": "An element with the identifier \"vfg\" must appear in the document.",
	"source": "xml",
	"startLineNumber": 19,
	"startColumn": 9,
	"endLineNumber": 19,
	"endColumn": 9
}

[fbricon]

Wrong attribute, underlines next attribute:

{
	"resource": "/Users/fbricon/Downloads/sample-resources/some.xml",
	"owner": "_generated_diagnostic_collection_name_#0",
	"code": "MSG_ATTRIBUTE_NOT_DECLARED",
	"severity": 8,
	"message": "Attribute \"Frien\" must be declared for element type \"Person\".",
	"source": "xml",
	"startLineNumber": 16,
	"startColumn": 32,
	"endLineNumber": 16,
	"endColumn": 37
}

[fbricon]

Unknown doctype node type:

{
	"resource": "/Users/fbricon/Downloads/sample-resources/some.xml",
	"owner": "_generated_diagnostic_collection_name_#0",
	"code": "MSG_MARKUP_NOT_RECOGNIZED_IN_DTD",
	"severity": 8,
	"message": "The markup declarations contained or pointed to by the document type declaration must be well-formed.",
	"source": "xml",
	"startLineNumber": 3,
	"startColumn": 7,
	"endLineNumber": 3,
	"endColumn": 7
}

[NikolasKomonen]

All above issues are addressed

[fbricon]

wrong ranges for

• MSG_ELEMENT_ALREADY_DECLARED (duplicate <!ELEMENT Email (#PCDATA)> )
• wrong range for PEReferenceWithinMarkup, see:

<!DOCTYPE Folks [
  <!ENTITY % Folks "(%bar;)*">
]>