Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with OSGi and p2 #288

Closed
mickaelistria opened this issue Jan 24, 2019 · 10 comments
Closed

Compatibility with OSGi and p2 #288

mickaelistria opened this issue Jan 24, 2019 · 10 comments
Labels
build enhancement New feature or request
Milestone

Comments

@mickaelistria
Copy link
Contributor

As we're integrating XML-LS in Eclipse IDE, it would be nice if the jar declared dependencies in the OSGi format as well (with a MANIFEST.MF). With this, then we'll more easily move away from the farjar which contains a lot of libraries we already have loaded in the application and can reuse.

@fbricon
Copy link
Contributor

fbricon commented Jan 25, 2019

I'm fine with that. Feel free to provide a quality patch ;-)

@mickaelistria
Copy link
Contributor Author

mickaelistria commented Jan 26, 2019 via email

@mickaelistria
Copy link
Contributor Author

I think we can just add http://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#adding-osgi-metadata-to-existing-projects-without-changing-the-packaging-type and adding a tycho-ecliserun mojo invocation to call p2 publisher in the pom.xml should do the trick.

mickaelistria added a commit to mickaelistria/lsp4xml that referenced this issue Feb 17, 2019
Signed-off-by: Mickael Istria <mistria@redhat.com>
@mickaelistria
Copy link
Contributor Author

Submitted PR #301 implementing what I mentioned in previous comment, this combined with https://www.jfrog.com/confluence/display/RTF/P2+Repositories would give total satisfaction.

mickaelistria added a commit to mickaelistria/lsp4xml that referenced this issue Feb 18, 2019
Signed-off-by: Mickael Istria <mistria@redhat.com>
mickaelistria added a commit to mickaelistria/lsp4xml that referenced this issue Feb 18, 2019
Signed-off-by: Mickael Istria <mistria@redhat.com>
fbricon pushed a commit that referenced this issue Feb 18, 2019
Signed-off-by: Mickael Istria <mistria@redhat.com>
@mickaelistria mickaelistria changed the title Add META-INF/MANIFEST.MF to xml-ls jar Compatibility with OSGi and p2 Feb 19, 2019
@mickaelistria
Copy link
Contributor Author

Thanks for merging the patch @fbricon . Could you please publish a build with the profile enabled and configure Artifactory so the p2 repo gets easily accessible: https://www.jfrog.com/confluence/display/RTF/P2+Repositories ?

@mickaelistria
Copy link
Contributor Author

Is there any progress on this topic? Did you manage to push a p2 repo to artifactory?

@fbricon
Copy link
Contributor

fbricon commented Mar 4, 2019

I got an artifactory-pro account from JFrog, now need to setup everything. Hopefully will be able to do that this week

@mickaelistria
Copy link
Contributor Author

Eclipse Simrel 2019-03 freezes in 11 days. So unless you can do it very soon, let's not rush and let's delay that for after the 15th.

@fbricon fbricon added this to the v0.4.0 milestone Mar 6, 2019
@fbricon
Copy link
Contributor

fbricon commented Mar 6, 2019

Snapshots deployed to https://lsp4xml.jfrog.io/lsp4xml/generic-local/p2/lsp4xml/0.4.0-SNAPSHOT/
Will comment about the release URL once 0.4.0 is out

@fbricon fbricon closed this as completed Mar 6, 2019
@mickaelistria
Copy link
Contributor Author

mickaelistria commented Mar 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants