Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection formatting ignores attribute indentation preference #429

Closed
fbricon opened this issue Jun 11, 2019 · 2 comments · Fixed by #431
Closed

Selection formatting ignores attribute indentation preference #429

fbricon opened this issue Jun 11, 2019 · 2 comments · Fixed by #431
Assignees
@xorye
Labels
bug Something isn't working formatting This issue or enhancement is related to formatting support
Milestone
v0.8.0

Comments

@fbricon
Copy link
Contributor

fbricon commented Jun 11, 2019

With "xml.format.splitAttributes": true, selection formatting still puts the 1st attribute on the same line as the opening tag:

Jun-11-2019 14-32-00
@xorye
Copy link

xorye commented Jun 12, 2019

@fbricon What do you think about this interaction?

attribute formatting example

I think it might be better so that only the second attribute becomes formatted since that is what is being selected, however, it will complicate things just a bit more.

@fbricon
Copy link
Contributor Author

fbricon commented Jun 12, 2019

I can live with that

@fbricon fbricon added this to the v0.8.0 milestone Jun 12, 2019
@xorye xorye mentioned this issue Jun 12, 2019
Merged
@angelozerr angelozerr added bug Something isn't working formatting This issue or enhancement is related to formatting support labels Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xorye xorye

Labels
bug Something isn't working formatting This issue or enhancement is related to formatting support
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Fix selection formatting ignoring split attribute indentation preference
3 participants
@fbricon @angelozerr @xorye