Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non XML Prologs not considered in Scanner #43

Closed
NikolasKomonen opened this issue Aug 7, 2018 · 3 comments
Closed

Non XML Prologs not considered in Scanner #43

NikolasKomonen opened this issue Aug 7, 2018 · 3 comments
Assignees
Milestone

Comments

@NikolasKomonen
Copy link
Contributor

JDT-LS uses <?m2e execute onConfiguration?> and this is not recognized in XMLScanner

@angelozerr
Copy link
Contributor

Indeed XML Scanner & XMLDocument must take care of prolog. We can see the problem when you format a XML file, the uprolog disapear.

@NikolasKomonen I affect you the issue (if you don't want to work on it, please tell me). It should be cool if you could fix too the format of XML with prolog and add tests. Thanks!

@angelozerr
Copy link
Contributor

@NikolasKomonen can we close this issue?

@NikolasKomonen
Copy link
Contributor Author

@angelozerr yeah, I'll close it.

@fbricon fbricon added this to the v0.0.1 milestone Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants