Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance and memory for validation by caching XML Schema / DTD #534

Closed
angelozerr opened this issue Jul 22, 2019 · 0 comments · Fixed by #572
Closed

Improve performance and memory for validation by caching XML Schema / DTD #534

angelozerr opened this issue Jul 22, 2019 · 0 comments · Fixed by #572
Assignees
@angelozerr
Labels
performance This issue or enhancement is related to performance concerns validation
Milestone
v0.9.1

Comments

@angelozerr
Copy link
Contributor

Today each time completion / validation based on XML Schema / DTD, the grammar is parsed.

We should cache those grammar to use it in completion and validation both (if it's possible) and reset the cache when file of the grammar is updated.
@angelozerr angelozerr added the performance This issue or enhancement is related to performance concerns label Jul 22, 2019
@fbricon fbricon added this to the v0.9.0 milestone Jul 22, 2019
@fbricon fbricon modified the milestones: v0.9.0, Sprint 171 Aug 20, 2019
@angelozerr angelozerr modified the milestones: Sprint 171, v0.9.0 Aug 22, 2019
@fbricon fbricon removed this from the v0.9.0 milestone Aug 30, 2019
angelozerr pushed a commit that referenced this issue Sep 4, 2019
Improve performance and memory by caching XML Schema / DTD
9d3a8b5 
Fixes #534


Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Sep 9, 2019
Improve performance and memory by caching XML Schema / DTD
c92a2f3 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 9, 2019
Improve performance and memory by caching XML Schema / DTD
22ae728 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Oct 9, 2019
Merged
@angelozerr angelozerr changed the title Improve performance and memory by caching XML Schema / DTD Improve performance and memory for validation by caching XML Schema / DTD Oct 10, 2019
@angelozerr angelozerr added this to the v0.9.1 milestone Oct 10, 2019
angelozerr pushed a commit that referenced this issue Oct 10, 2019
Improve performance and memory by caching XML Schema / DTD
d5fbf70 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 10, 2019
Improve performance and memory by caching XML Schema / DTD
8924e2e 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 10, 2019
Improve performance and memory by caching XML Schema / DTD
4720cd2 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 10, 2019
Improve performance and memory by caching XML Schema / DTD
36ef1cf 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 14, 2019
Improve performance and memory by caching XML Schema / DTD
0b08f85 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 14, 2019
Improve performance and memory by caching XML Schema / DTD
63c4751 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 15, 2019
Improve performance and memory by caching XML Schema / DTD
d72a2d9 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 15, 2019
Improve performance and memory by caching XML Schema / DTD
6577cc1 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 15, 2019
Improve performance and memory by caching XML Schema / DTD
db69af4 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 15, 2019
Improve performance and memory by caching XML Schema / DTD
e88c43e 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit that referenced this issue Oct 15, 2019
Improve performance and memory by caching XML Schema / DTD
012f1b4 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
fbricon pushed a commit that referenced this issue Oct 15, 2019
@fbricon
Improve performance and memory by caching XML Schema / DTD
f8a2c15 
Fixes #534

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
performance This issue or enhancement is related to performance concerns validation
Projects
None yet
Milestone
v0.9.1
Development

Successfully merging a pull request may close this issue.

Improve performance and memory for validation by caching XML Schema / DTD eclipse/lemminx
2 participants
@fbricon @angelozerr