Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Error Message Fails on Certain Cases #553

Closed
NikolasKomonen opened this issue Aug 13, 2019 · 2 comments · Fixed by #557
Closed

Validation Error Message Fails on Certain Cases #553

NikolasKomonen opened this issue Aug 13, 2019 · 2 comments · Fixed by #557
Assignees
Milestone

Comments

@NikolasKomonen
Copy link
Contributor

First found from this issue: redhat-developer/vscode-xml#177 (comment)

The line of code that looks like this, https://github.com/angelozerr/lsp4xml/blob/fee585992ab5c1748708cf92aada4c7f01c7f220/org.eclipse.lsp4xml/src/main/java/org/eclipse/lsp4xml/extensions/contentmodel/participants/XMLSchemaErrorCode.java#L155

fails because the type we are casting it to is not always a string in certain cases.

Instead use the toString() method, make a StringUtils method to handle this issue.

@NikolasKomonen
Copy link
Contributor Author

@skjardenCode

Does this fix the issue you were having in redhat-developer/vscode-xml#177 (comment)?

image

NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Aug 15, 2019
Fixes eclipse#553

Signed-off-by: NikolasKomonen <nikolaskomonen@gmail.com>
@angelozerr angelozerr added this to the v0.9.0 milestone Aug 17, 2019
@angelozerr
Copy link
Contributor

angelozerr commented Aug 17, 2019

@NikolasKomonen I think you have fixed the issue. Could you create a PR please?

NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Aug 19, 2019
Fixes eclipse#553

Signed-off-by: NikolasKomonen <nikolaskomonen@gmail.com>
angelozerr pushed a commit that referenced this issue Aug 19, 2019
Fixes #553

Signed-off-by: NikolasKomonen <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants