Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for textDocument/documentLink #56

Closed
angelozerr opened this issue Aug 11, 2018 · 2 comments
Closed

Add support for textDocument/documentLink #56

angelozerr opened this issue Aug 11, 2018 · 2 comments
Assignees
@angelozerr
Labels
CM Extension Content Model extension (XML Schema & DTD) enhancement New feature or request
Milestone
v0.0.2

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Aug 11, 2018 •
edited

Add support for textDocument/documentLink https://microsoft.github.io/language-server-protocol/specification#textDocument_documentLink for extension.

One extension for web (web.xml) could manage hyperlink for welcome-file to open it:

<welcome-file-list>
     <welcome-file>index.jsp</welcome-file>
     <welcome-file>index.html</welcome-file>
</welcome-file-list>

One extension for String could manage hyperlink for class to open the Java class:

<bean class="MyClass" />
angelozerr added a commit that referenced this issue Aug 11, 2018
@angelozerr
Initialize support for documentLink (see #56)
3218682
@fbricon fbricon added the enhancement New feature or request label Sep 7, 2018
@fbricon
Copy link
Contributor

fbricon commented Nov 3, 2018

Is it complete now? Because we can navigate to schemas defined in xsi:noNamespaceSchemaLocation for instance.

web.xml hyperlink is a specific use case I wouldn't worry about for now.

@angelozerr angelozerr self-assigned this Nov 3, 2018
@angelozerr angelozerr added this to the v0.0.2 milestone Nov 3, 2018
@angelozerr angelozerr added the CM Extension Content Model extension (XML Schema & DTD) label Nov 3, 2018
@angelozerr
Copy link
Contributor Author

Is it complete now?

yes extension is done

Because we can navigate to schemas defined in xsi:noNamespaceSchemaLocation for instance.

exactly and it exists test for this feature at https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/extensions/contentmodel/XMLSchemaDocumentLinkTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
CM Extension Content Model extension (XML Schema & DTD) enhancement New feature or request
Projects
None yet
Milestone
v0.0.2
Development

No branches or pull requests
2 participants
@fbricon @angelozerr