Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo: "suppress", not "supres" (two 'p's) #57

Closed
JoshuaKGoldberg opened this issue Jan 10, 2018 · 7 comments
Closed

Typo: "suppress", not "supres" (two 'p's) #57

JoshuaKGoldberg opened this issue Jan 10, 2018 · 7 comments

Comments

@JoshuaKGoldberg
Copy link

No description provided.

@angelozerr
Copy link
Owner

Where is there this typo? Can we have a PR?

@angelozerr
Copy link
Owner

I close this issuse since I think it's an error coming from a tslint rule. We don't use 'supres' in our code.

@JoshuaKGoldberg
Copy link
Author

I... honestly have no idea what the context was here. Probably the wrong repository.

@JoshuaKGoldberg
Copy link
Author

Oh! Found it. @angelozerr

supressWhileTypeErrorsPresent - should be suppressWhileTypeErrorsPresent. Incorrect spelling à la "referer".

@angelozerr angelozerr reopened this Apr 6, 2018
@angelozerr
Copy link
Owner

Thanks @JoshuaKGoldberg ! We must fix it. Can we have a PR please?

@JoshuaKGoldberg
Copy link
Author

I'd be happy to. Since this is a breaking change, how do you want to approach versioning?

Proposal: bump the version to 0.10 and allow both flags, with a console.warn on the old one. When you hit 1.0, remove the old one?

@angelozerr
Copy link
Owner

Yes you are right. @egamma what do you think about that?

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@angelozerr @JoshuaKGoldberg