Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing shadows #52

Open
angered-ghandi opened this issue Aug 9, 2016 · 0 comments
Open

Missing shadows #52

angered-ghandi opened this issue Aug 9, 2016 · 0 comments

Comments

@angered-ghandi
Copy link
Owner

Now that the game is rendering delta graphics (see #37), there are a hundreds of TODO comments being printed out when the game starts up:

...
TODO: skipped 15 instead of drawing the shadow
TODO: skipped 20 instead of drawing the shadow
TODO: skipped 13 instead of drawing the shadow
TODO: skipped 13 instead of drawing the shadow
TODO: skipped 7 instead of drawing the shadow
...

I made it draw yellow instead of skipping, and it looks like several of the delta graphics are nothing but shadows:
missing_shadows

Unfortunately, with the way the SLP crate is currently laid out, it's not going to be easy to correctly implement the actual shadows. In the original game, it'd use the index of the color in the destination pixel buffer to determine the shadow color to draw. We'll need to do something clever here since that's not feasible with OpenGL (at least not with good performance). Might be able to make it look as close to the original as possible using a pixel shader, but being able to use a shader will require a rewrite of the whole render system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant