Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A question about routes order... #3

Closed
0xsimulacra opened this issue Jan 22, 2022 · 1 comment
Closed

A question about routes order... #3

0xsimulacra opened this issue Jan 22, 2022 · 1 comment

Comments

@0xsimulacra
Copy link

0xsimulacra commented Jan 22, 2022

Hello,

Thank you for the great paper, the thoughtful explanation in it and the accompanied code. It really helps someone like me.

I have one or two question please :

  1. If I understood very well your formulation about including transaction cost in the objective function and without thinking about the fact that the problem is solvable or not, the way you included the transaction cost is by adding a constant transaction cost for each CFMM, meaning if we do one trade in that CFMM we'll have to pay that transaction cost, while in reality the transaction cost is dependent not on if we did a trade or not on a CFMM but on how many trades we did on that CFMM and your formula omit this detail. Am I right ?

Your response for these questions will be so much helpful.

@angeris
Copy link
Owner

angeris commented Feb 2, 2022

Thanks!

I think we will leave the question of how to add the gas cost of doing multiple trades on currently-implemented CFMMs as an exercise to the reader :)

(Maybe more specifically: there is no real reason why Balancer, e.g., can't allow multi-asset trades to happen in a single contract call, which is the case we were considering here.)

@angeris angeris closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants