Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nx 16 breaks the module-federation schematic #315

Closed
lbueker opened this issue Apr 28, 2023 · 2 comments
Closed

Nx 16 breaks the module-federation schematic #315

lbueker opened this issue Apr 28, 2023 · 2 comments

Comments

@lbueker
Copy link

lbueker commented Apr 28, 2023

Since version 16 nx switched their package scope from @nrwl to @nx
nrwl/nx#16069

This breaks the module-federation schematic:

 nx g @angular-architects/module-federation:init --type=dynamic-host
 ...
TypeError: Cannot read properties of undefined (reading 'split')
    at new Range (C:\...\module-federation-poc\node_modules\semver\classes\range.js:32:8)
    at Object.minVersion (C:\...\module-federation-poc\node_modules\semver\ranges\min-version.js:6:11)
    at infereNxBuilderNames (C:\...\module-federation-poc\node_modules\@angular-architects\module-federation\src\schematics\mf\schematic.js:130:31)
    at C:\...\module-federation-poc\node_modules\@angular-architects\module-federation\src\schematics\mf\schematic.js:211:36
    at Generator.next (<anonymous>)
    at fulfilled (C:\...\module-federation-poc\node_modules\tslib\tslib.js:164:62)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

 >  NX   Cannot read properties of undefined (reading 'split')

This is in a freshly setup angular nx workspace.
nx version: 16.0.0
angular version: 15.2.0
@angular-architects/module-federation version: 15.0.3

@manfredsteyer
Copy link
Contributor

Thanks. Meanwhile, we have version 16 that works with Angular 16 and Nx 16.0 + Nx 16.1. Last time I checked, there was an issue with Nx 16.2 preventing it to work.

@manfredsteyer
Copy link
Contributor

Works again with NX 16.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants