Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make route matching more explicit #25

Merged
merged 1 commit into from
Jul 21, 2020
Merged

fix: make route matching more explicit #25

merged 1 commit into from
Jul 21, 2020

Conversation

brandonroberts
Copy link
Collaborator

Closes #18

BREAKING CHANGE:

Removes usage of /** pattern for parent and wildcard routes

BEFORE:

  <route path="/books/**"></route>

AFTER:

  <route path="/books" [exact]="false">

@brandonroberts
fix: make route matching more explicit
d0cec31 
BREAKING CHANGE:

Removes usage of `/**` pattern for parent and wildcard routes

BEFORE:

```html
  <route path="/books/**"></route>
```

AFTER:

```html
  <route path="/books" [exact]="false">
```
@brandonroberts brandonroberts merged commit 3b8716b into master Jul 21, 2020
@brandonroberts brandonroberts deleted the fix-route-matching branch July 21, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Nested routes do not abide 404
1 participant
@brandonroberts