fix(parser): pass base to URL only when value is provided #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Safari attempting to pass
base
asundefined
results withTypeError
as seen on https://responsive-ng-router.netlify.app.Based on type definition for URL,
base
property is optional and of typestring | URL
. While most browsers consider passing undefined and omitting the property same, Safari is somewhat strict in this matter and throws an exception.