Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): add more demos #68

Merged
merged 3 commits into from
Dec 22, 2020
Merged

feat(demo): add more demos #68

merged 3 commits into from
Dec 22, 2020

Conversation

meeroslav
Copy link
Collaborator

@meeroslav meeroslav commented Dec 15, 2020

  • Recursive demo
  • Restrictions demo
  • Responsive demo

@meeroslav meeroslav added this to In progress in 0.4.0 release via automation Dec 15, 2020
@brandonroberts
Copy link
Collaborator

I don't think we need separate demos for each of these. What do you think about rolling them into one demo app?

@meeroslav
Copy link
Collaborator Author

Each one of them is targeting a different feature. It makes it easier for devs to find an example of how to do a specific thing. This could be a base for documentation. Additionally, including E2E tests into CI brings extra checks.

Merging them all together would create a multi-concern app that would be harder to read.

I would, though, remove the getting-started and tour-of-heroes and replace them with demo apps showing the @angular/router working alongside angular-routing and "auxiliary routes" (multiple routers on the same component).

What do you think about this proposal?

@brandonroberts
Copy link
Collaborator

That sounds reasonable to me

@meeroslav
Copy link
Collaborator Author

Please merge this one in then and I'll create additional PR for new demos and removal of the two above mentioned

@brandonroberts brandonroberts merged commit 9ed17ec into master Dec 22, 2020
0.4.0 release automation moved this from In progress to Done Dec 22, 2020
@brandonroberts brandonroberts deleted the examples branch December 22, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants