Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin-template): [no-interpolation-in-attributes] new rule #1242

Merged

Conversation

undsoft
Copy link
Contributor

@undsoft undsoft commented Nov 30, 2022

Fixes #1171

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1242 (e311edd) into main (4ef0290) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1242      +/-   ##
==========================================
+ Coverage   88.04%   88.11%   +0.06%     
==========================================
  Files         162      164       +2     
  Lines        3154     3172      +18     
  Branches      512      512              
==========================================
+ Hits         2777     2795      +18     
  Misses        261      261              
  Partials      116      116              
Flag Coverage Δ
unittest 88.11% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin-template/src/index.ts 69.81% <ø> (+0.58%) ⬆️
.../template-parser/src/convert-source-span-to-loc.ts 22.72% <ø> (ø)
...mplate/src/rules/no-interpolation-in-attributes.ts 100.00% <100.00%> (ø)
...ests/rules/no-interpolation-in-attributes/cases.ts 100.00% <100.00%> (ø)

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @undsoft!

@JamesHenry JamesHenry merged commit 977cb3a into angular-eslint:main Dec 7, 2022
@undsoft undsoft deleted the no-interpolation-in-attributes branch December 7, 2022 15:52
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jan 16, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular-eslint/builder](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`15.1.0` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2fbuilder/15.1.0/15.2.0) |
| [@angular-eslint/eslint-plugin](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`15.1.0` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin/15.1.0/15.2.0) |
| [@angular-eslint/eslint-plugin-template](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`15.1.0` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2feslint-plugin-template/15.1.0/15.2.0) |
| [@angular-eslint/schematics](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`15.1.0` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2fschematics/15.1.0/15.2.0) |
| [@angular-eslint/template-parser](https://github.com/angular-eslint/angular-eslint) | devDependencies | minor | [`15.1.0` -> `15.2.0`](https://renovatebot.com/diffs/npm/@angular-eslint%2ftemplate-parser/15.1.0/15.2.0) |

---

### Release Notes

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/builder)</summary>

### [`v15.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/builder/CHANGELOG.md#&#8203;1520-httpsgithubcomangular-eslintangular-eslintcomparev1510v1520-2023-01-14)

[Compare Source](angular-eslint/angular-eslint@v15.1.0...v15.2.0)

**Note:** Version bump only for package [@&#8203;angular-eslint/builder](https://github.com/angular-eslint/builder)

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/eslint-plugin)</summary>

### [`v15.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;1520-httpsgithubcomangular-eslintangular-eslintcomparev1510v1520-2023-01-14)

[Compare Source](angular-eslint/angular-eslint@v15.1.0...v15.2.0)

##### Bug Fixes

-   **eslint-plugin:** \[component-selector] enhance check for prefix and kebab-case ([#&#8203;1250](angular-eslint/angular-eslint#1250)) ([16827e4](angular-eslint/angular-eslint@16827e4))
-   **eslint-plugin:** \[no-inputs-metadata-property] do not report on directive composition API ([#&#8203;1248](angular-eslint/angular-eslint#1248)) ([539cf9f](angular-eslint/angular-eslint@539cf9f))
-   update typescript-eslint packages to v5.45.1 ([#&#8203;1239](angular-eslint/angular-eslint#1239)) ([abb7f79](angular-eslint/angular-eslint@abb7f79))
-   update typescript-eslint packages to v5.48.1 ([#&#8203;1255](angular-eslint/angular-eslint#1255)) ([11151d1](angular-eslint/angular-eslint@11151d1))

##### Features

-   **eslint-plugin:** \[require-localize-metadata] option to require meaning ([#&#8203;1235](angular-eslint/angular-eslint#1235)) ([b870123](angular-eslint/angular-eslint@b870123))

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/eslint-plugin-template)</summary>

### [`v15.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/eslint-plugin-template/CHANGELOG.md#&#8203;1520-httpsgithubcomangular-eslintangular-eslintcomparev1510v1520-2023-01-14)

[Compare Source](angular-eslint/angular-eslint@v15.1.0...v15.2.0)

##### Bug Fixes

-   update typescript-eslint packages to v5.45.1 ([#&#8203;1239](angular-eslint/angular-eslint#1239)) ([abb7f79](angular-eslint/angular-eslint@abb7f79))
-   update typescript-eslint packages to v5.48.1 ([#&#8203;1255](angular-eslint/angular-eslint#1255)) ([11151d1](angular-eslint/angular-eslint@11151d1))

##### Features

-   **eslint-plugin-template:** \[i18n] option to require i18n metadata meaning ([#&#8203;1234](angular-eslint/angular-eslint#1234)) ([4ef0290](angular-eslint/angular-eslint@4ef0290))
-   **eslint-plugin-template:** \[no-interpolation-in-attributes] new rule added ([#&#8203;1242](angular-eslint/angular-eslint#1242)) ([977cb3a](angular-eslint/angular-eslint@977cb3a))

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/schematics)</summary>

### [`v15.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/schematics/CHANGELOG.md#&#8203;1520-httpsgithubcomangular-eslintangular-eslintcomparev1510v1520-2023-01-14)

[Compare Source](angular-eslint/angular-eslint@v15.1.0...v15.2.0)

##### Bug Fixes

-   update dependency eslint to v8.29.0 ([#&#8203;1246](angular-eslint/angular-eslint#1246)) ([10c14d2](angular-eslint/angular-eslint@10c14d2))
-   update dependency eslint to v8.31.0 ([#&#8203;1262](angular-eslint/angular-eslint#1262)) ([db89c85](angular-eslint/angular-eslint@db89c85))
-   update dependency ignore to v5.2.1 ([#&#8203;1237](angular-eslint/angular-eslint#1237)) ([609e06b](angular-eslint/angular-eslint@609e06b))
-   update dependency ignore to v5.2.4 ([#&#8203;1263](angular-eslint/angular-eslint#1263)) ([a220e0c](angular-eslint/angular-eslint@a220e0c))
-   update typescript-eslint packages to v5.45.1 ([#&#8203;1239](angular-eslint/angular-eslint#1239)) ([abb7f79](angular-eslint/angular-eslint@abb7f79))
-   update typescript-eslint packages to v5.48.1 ([#&#8203;1255](angular-eslint/angular-eslint#1255)) ([11151d1](angular-eslint/angular-eslint@11151d1))

</details>

<details>
<summary>angular-eslint/angular-eslint (@&#8203;angular-eslint/template-parser)</summary>

### [`v15.2.0`](https://github.com/angular-eslint/angular-eslint/blob/HEAD/packages/template-parser/CHANGELOG.md#&#8203;1520-httpsgithubcomangular-eslintangular-eslintcomparev1510v1520-2023-01-14)

[Compare Source](angular-eslint/angular-eslint@v15.1.0...v15.2.0)

##### Features

-   **eslint-plugin-template:** \[no-interpolation-in-attributes] new rule added ([#&#8203;1242](angular-eslint/angular-eslint#1242)) ([977cb3a](angular-eslint/angular-eslint@977cb3a))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDIuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMi4wIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1733
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: no interpolation in attributes
2 participants