Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-template): [attributes-order] fixes for structural directives and "dotted" names #1448

Merged

Conversation

pmccloghrylaing
Copy link
Contributor

Fixes #1197

@pmccloghrylaing pmccloghrylaing force-pushed the attributes-order-structural-directives branch from 3df6a1c to 3e887be Compare July 11, 2023 05:20
@pmccloghrylaing pmccloghrylaing changed the title fix: handle structural directives like *ngForOf fix(eslint-plugin-template): [attributes-order] fixes for structural directives and "dotted" names Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #1448 (efaf627) into main (02c2a97) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
- Coverage   89.36%   89.29%   -0.07%     
==========================================
  Files         162      162              
  Lines        3019     3028       +9     
  Branches      507      510       +3     
==========================================
+ Hits         2698     2704       +6     
  Misses        201      201              
- Partials      120      123       +3     
Flag Coverage Δ
unittest 89.29% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lint-plugin-template/src/rules/attributes-order.ts 96.80% <100.00%> (-3.20%) ⬇️
...gin-template/tests/rules/attributes-order/cases.ts 100.00% <100.00%> (ø)

@abaran30 abaran30 merged commit 90c0e91 into angular-eslint:main Jul 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@angular-eslint/template/attributes-order] fixer is broken
3 participants