feat(eslint-plugin-template): allow alias option in [use-track-by-function]
#1497
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8f3bbe8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targetsSent with 💌 from NxCloud. |
…unction] This commit adds an `alias` option to the `use-track-by-function` rule, allowing the specification of a list of properties that should be treated similarly to `ngForTrackBy`.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1497 +/- ##
==========================================
+ Coverage 89.23% 89.55% +0.32%
==========================================
Files 162 166 +4
Lines 3056 3113 +57
Branches 521 526 +5
==========================================
+ Hits 2727 2788 +61
+ Misses 201 195 -6
- Partials 128 130 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Why did this require changing a jest config?
There was a problem hiding this comment.
This is causing warnings to appear in the console, and these warnings are overlapping everything I logged with console.log.
There was a problem hiding this comment.
Please add a full ng-template example of using the custom directive (both a passing and failing case, like we have elsewhere in this file
|
You need to run |
This commit adds an
aliasoption to theuse-track-by-functionrule, allowing the specification of a list of properties that should be treated similarly tongForTrackBy.Closes #1323