fix(eslint-plugin-template): [prefer-self-closing-tags] improve code style of fixer result #1520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running the fixer of the
prefer-self-closing-tags
rule, in some scenarios a result is generated, which is considered as bad code style by common sense and formatters like prettier. More specifically, currently the fixer always adds an additional whitespace before the self closing tag. However when the end of the starting tag is indented or on a new line, this additional whitespace produces misalignment.For example, take the following code:
Currently the fixer would produce the following reusult:
With the changes of this PR it would become: