fix(eslint-plugin-template): accessibility-valid-aria not reporting i… #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvalid 'aria-' values
rafaelss95
commented
Jan 3, 2021
Comment on lines
17
to
21
| // As in the time it being write the `ARIAPropertyDefinition` (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/64ae44025dbd41afb3b865ca37deddef7de1c5fb/types/aria-query/index.d.ts#L302-L306) | ||
| // is incorrect (`value` should be `values`), we created this hackish type to avoid `any`. | ||
| type ARIAPropertyDefinitionHack = Omit<ARIAPropertyDefinition, 'value'> & { | ||
| readonly values: ARIAPropertyDefinition['value']; | ||
| }; |
There was a problem hiding this comment.
I hope the comment is clear enough to express the intent.
There was a problem hiding this comment.
Thanks yes, made sense, just added some minor English language suggestions
There was a problem hiding this comment.
I've opened a PR in the DefinitelyTyped repo: DefinitelyTyped/DefinitelyTyped#50528. What do you think about delaying this merge a little bit until the PR is merged? Of course, if it takes too long to merge, we can move on as is.
There was a problem hiding this comment.
I removed this as DefinitelyTyped/DefinitelyTyped#50528 has been merged.
JamesHenry
requested changes
Jan 11, 2021
|
|
||
| import { | ||
| createESLintRule, | ||
| getTemplateParserServices, | ||
| } from '../utils/create-eslint-rule'; | ||
|
|
||
| // As in the time it being write the `ARIAPropertyDefinition` (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/64ae44025dbd41afb3b865ca37deddef7de1c5fb/types/aria-query/index.d.ts#L302-L306) |
There was a problem hiding this comment.
Suggested change
| // As in the time it being write the `ARIAPropertyDefinition` (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/64ae44025dbd41afb3b865ca37deddef7de1c5fb/types/aria-query/index.d.ts#L302-L306) | |
| // At the time of writing, the `ARIAPropertyDefinition` (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/64ae44025dbd41afb3b865ca37deddef7de1c5fb/types/aria-query/index.d.ts#L302-L306) |
|
|
||
| import { | ||
| createESLintRule, | ||
| getTemplateParserServices, | ||
| } from '../utils/create-eslint-rule'; | ||
|
|
||
| // As in the time it being write the `ARIAPropertyDefinition` (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/64ae44025dbd41afb3b865ca37deddef7de1c5fb/types/aria-query/index.d.ts#L302-L306) | ||
| // is incorrect (`value` should be `values`), we created this hackish type to avoid `any`. |
There was a problem hiding this comment.
Suggested change
| // is incorrect (`value` should be `values`), we created this hackish type to avoid `any`. | |
| // is incorrect (`value` should be `values`), we created this hacky workaround type to avoid `any`. |
Comment on lines
17
to
21
| // As in the time it being write the `ARIAPropertyDefinition` (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/64ae44025dbd41afb3b865ca37deddef7de1c5fb/types/aria-query/index.d.ts#L302-L306) | ||
| // is incorrect (`value` should be `values`), we created this hackish type to avoid `any`. | ||
| type ARIAPropertyDefinitionHack = Omit<ARIAPropertyDefinition, 'value'> & { | ||
| readonly values: ARIAPropertyDefinition['value']; | ||
| }; |
There was a problem hiding this comment.
Thanks yes, made sense, just added some minor English language suggestions
…rting invalid 'aria-' values
…s95/angular-eslint into fix/accessibility-valid-aria-value
…o fix/accessibility-valid-aria-value
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nvalid 'aria-' values
Relates to #272 (comment).
PS: Not sure it should be considered a feat or a fix.