fix(eslint-plugin): component-max-inline-declarations animations not being checked properly #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
force-pushed
the
fix/component-max-inline-declarations
branch
2 times, most recently
from
5eff241
to
417ced6
Compare
rafaelss95
changed the title
rafaelss95
force-pushed
the
fix/component-max-inline-declarations
branch
3 times, most recently
from
222358f
to
7d57a41
Compare
JamesHenry
requested changes
Jan 26, 2021
packages/eslint-plugin/tests/rules/component-max-inline-declarations.test.ts
Show resolved
Hide resolved
packages/eslint-plugin/tests/rules/component-max-inline-declarations.test.ts
Show resolved
Hide resolved
JamesHenry
added
the
BREAKING CHANGE
rafaelss95
force-pushed
the
fix/component-max-inline-declarations
branch
from
7d57a41
to
3f0ab15
Compare
rafaelss95
force-pushed
the
fix/component-max-inline-declarations
branch
from
3f0ab15
to
12bf62b
Compare
rafaelss95
force-pushed
the
fix/component-max-inline-declarations
branch
from
12bf62b
to
5cd7e35
Compare
JamesHenry
approved these changes
Feb 6, 2021
JamesHenry
removed
the
BREAKING CHANGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a fix for #304, I noticed that we could clean up this rule/tests, and so I did. Here's the context of each commit:
First commit: Currently we perform some checks to verify that the received limit is >
-1. Now, we rely on the schema that can handle it automatically.Second commit: Currently we use the function
getDecoratorPropertyValueto get the desired property. Now, we use selectors instead.Third commit: The tests are a bit verbose with a lot of annotations and also we don't check if the lines are calculated properly. With this commit, we have cleaner tests with properties checking through
data.Fourth commit: Fixes #304, before this commit we were calculating animation lines as
string, however it isn't. Now, it may be checked properly.