Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-parser): add BindingPipe exp to VisitorKeys (#337) #338

Merged
merged 1 commit into from Mar 8, 2021

Conversation

detljh
Copy link
Contributor

@detljh detljh commented Feb 12, 2021

Added BindingPipe: ['exp'] to template-parser for (#337)

@nx-cloud
Copy link

nx-cloud bot commented Feb 12, 2021

Nx Cloud Report

CI ran the following commands for commit b496244. Click to see the status, the terminal output, and the build insights.

Status Command Start Time
#000000 nx run-many --target=build --all --parallel 2/12/2021, 6:53:52 AM
#000000 nx run-many --target=check-configs --all --parallel 2/12/2021, 6:54:57 AM
#000000 nx run-many --target=test --all --parallel 2/12/2021, 6:54:03 AM
#000000 nx run-many --target=typecheck --all --parallel 2/12/2021, 6:54:14 AM

Sent with 💌 from NxCloud.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please also add some relevant test coverage in the template plugin which captures the source you initially discovered this issue on

@detljh
Copy link
Contributor Author

detljh commented Feb 12, 2021

Sorry I'm not sure where I would add relevant tests

@JamesHenry
Copy link
Member

@detljh You reference tests from this repo in your original bug report - I'm simply referring to have an example of what was missing before and how you originally found this

@detljh
Copy link
Contributor Author

detljh commented Mar 7, 2021

Oh in my original bug report those tests weren't from this repo. I found the bug while creating tests for a rule I wrote

@JamesHenry
Copy link
Member

@detljh Ah ok, well yeah I think we currently don't have anything in this repo which is affected by this, but I agree it makes sense to have, so I'm going to merge it

@JamesHenry JamesHenry merged commit 75c406f into angular-eslint:master Mar 8, 2021
@detljh detljh deleted the binding-pipe-visitor-key branch March 8, 2021 09:55
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants