-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(template-parser): add BindingPipe exp to VisitorKeys (#337) #338
fix(template-parser): add BindingPipe exp to VisitorKeys (#337) #338
Conversation
Nx Cloud ReportCI ran the following commands for commit b496244. Click to see the status, the terminal output, and the build insights.
Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please also add some relevant test coverage in the template plugin which captures the source you initially discovered this issue on
Sorry I'm not sure where I would add relevant tests |
@detljh You reference tests from this repo in your original bug report - I'm simply referring to have an example of what was missing before and how you originally found this |
Oh in my original bug report those tests weren't from this repo. I found the bug while creating tests for a rule I wrote |
@detljh Ah ok, well yeah I think we currently don't have anything in this repo which is affected by this, but I agree it makes sense to have, so I'm going to merge it |
Added
BindingPipe: ['exp']
totemplate-parser
for (#337)