refactor(eslint-plugin-template): no-negated-async no longer perform equality checks #399
Conversation
rafaelss95
added
the
BREAKING CHANGE
Nx Cloud ReportCI ran the following commands for commit 1766ce5. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
Nx Cloud ReportCI ran the following commands for commit 42dccdd. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Yeah seems like a good idea, and we'll definitely want to ensure we don't lose functionality overall. So:
- add back the equality as a new rule (feat(eslint-plugin-template): add rule eqeqeq #444)
- add a migration in for user configs (build: v12 migrations #447)
- change the base branch of this PR to
v3next-major-release/v12and rebase - Merge this PR into
next-major-release/v12
|
I'd like to get v3 out as soon as we can so going to mark this one for v12 (the next major version to align us with the next major angular version) |
|
@rafaelss95 No worries if not, but do you think you'll be able to work on this this week? Angular 12 is getting released today and I'd like to follow it up with @angular-eslint 12 stable as soon as we can. This will be our last breaking change until Angular 13 so that we can stay aligned with Angular's own major version to make it really straightforward for users |
Oh, I'll try to do my best. PR for the new rule is open: #444. I'll try to work on a migration now. Btw, what should the migration do? Add the new equality rule? |
|
@rafaelss95 Yes exactly, whatever it takes to achieve no change in behaviour when running |
|
I have changed the base branch to be the v12 one, which already has the start of the migration in for v12 so you just need to add to that |
|
I've turned my previous comment into a TODO list |
|
@rafaelss95 Are you clear on the next steps above? |
|
Thanks @rafaelss95 I've updated the list with the progess, I will open the PR to |
|
We can apply the updated tslint-to-eslint-config outside this branch, so please go ahead and get this PR ready for final review |
rafaelss95
force-pushed
the
refactor/no-negated-async-pipe-remove-strict-equality
branch
from
42dccdd
to
1766ce5
Compare
rafaelss95
changed the title
rafaelss95
deleted the
refactor/no-negated-async-pipe-remove-strict-equality
branch
…ality checks (#399) BREAKING CHANGE You should add the new `@angular-eslint/template/eqeqeq` rule to your config if you want to continue with the same functionality around equality checks. This will be applied for you by `ng update` automatically.
…ality checks (#399) BREAKING CHANGE You should add the new `@angular-eslint/template/eqeqeq` rule to your config if you want to continue with the same functionality around equality checks. This will be applied for you by `ng update` automatically.
BREAKING CHANGE.
Currently it's a proposal. If it gets approved, we could implement a rule to perform equality checks.
Fixes #315.