Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to --cache-strategy option #410

Closed
1 task done
pabloiocampo opened this issue Apr 14, 2021 · 2 comments · Fixed by #520
Closed
1 task done

Add support to --cache-strategy option #410

pabloiocampo opened this issue Apr 14, 2021 · 2 comments · Fixed by #520
Assignees
Labels
enhancement New feature or request package: builder Angular CLI builder which enables executing ESLint in Angular CLI workspaces PRs Welcome If a high-quality PR is created for this it will be accepted

Comments

@pabloiocampo
Copy link

pabloiocampo commented Apr 14, 2021

Description and reproduction of the issue
Please, add --cache-strategy option to ng lint. Option --cache works fine. I have @angular-eslint/builder up to 2.1.0.

Versions

     _                      _                 ____ _     ___ 
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | | 
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | | 
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 11.2.8
Node: 14.16.0
OS: win32 x64

Angular: 11.2.9
... animations, common, compiler, compiler-cli, core, forms    
... platform-browser, platform-browser-dynamic, platform-server
... router, service-worker
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------      
@angular-devkit/architect       0.1102.7
@angular-devkit/build-angular   0.1102.7
@angular-devkit/core            11.2.7
@angular-devkit/schematics      11.2.8
@angular/cdk                    11.2.8
@angular/cli                    11.2.8
@angular/fire                   6.1.4
@angular/material               11.2.8
@nguniversal/builders           11.2.1
@nguniversal/express-engine     11.2.1
@schematics/angular             11.2.8
@schematics/update              0.1102.8
rxjs                            6.6.7
typescript                      4.1.5
  • I have updated to the latest supported version of the packages and checked my ng version output per the instructions given here.
@pabloiocampo pabloiocampo added package: builder Angular CLI builder which enables executing ESLint in Angular CLI workspaces triage This issue needs to be looked at and categorized by a maintainer labels Apr 14, 2021
@JamesHenry JamesHenry added enhancement New feature or request PRs Welcome If a high-quality PR is created for this it will be accepted and removed triage This issue needs to be looked at and categorized by a maintainer labels Apr 19, 2021
@hoeni
Copy link

hoeni commented May 28, 2021

Please also add the missing --cache-location

@rafaelss95
Copy link
Member

Please also add the missing --cache-location

I guess it's already supported as it's present on builder#schema.json:

"cacheLocation": {
"type": "string",
"description": "Path to the cache file or directory."
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package: builder Angular CLI builder which enables executing ESLint in Angular CLI workspaces PRs Welcome If a high-quality PR is created for this it will be accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants