Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-template): [i18n] remove unsafe fix #411

Merged
merged 1 commit into from Apr 17, 2021

Conversation

rafaelss95
Copy link
Member

Fixes #400.

@@ -248,15 +248,9 @@ export default createESLintRule<Options, MessageIds>({
)),
)
) {
// If at least one child is a text node then we probably need i18n
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the comment says: "[...] we probably need i18n". I decided to remove this as we can't guarantee that this fix is safe.

@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #411 (45ae584) into master (7870d1e) will increase coverage by 1.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   63.88%   65.60%   +1.72%     
==========================================
  Files          12       10       -2     
  Lines         443      410      -33     
  Branches       74       64      -10     
==========================================
- Hits          283      269      -14     
+ Misses        132      114      -18     
+ Partials       28       27       -1     
Impacted Files Coverage Δ
.../template-parser/src/convert-source-span-to-loc.ts
packages/builder/src/utils/eslint-utils.ts

@nx-cloud
Copy link

nx-cloud bot commented Apr 15, 2021

Nx Cloud Report

CI ran the following commands for commit 45ae584. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@JamesHenry JamesHenry merged commit 3246b8a into angular-eslint:master Apr 17, 2021
@JamesHenry
Copy link
Member

In the future we could possibly leverage "suggestions" for these cases: https://eslint.org/docs/developer-guide/working-with-rules#providing-suggestions

I haven't used them before myself but they are a possibility

@rafaelss95 rafaelss95 deleted the fix/400 branch April 20, 2021 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[i18n] fix adds errors to templates
2 participants