Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schematics): add add-eslint-to-project schematic #426

Merged
merged 1 commit into from Apr 28, 2021

Conversation

JamesHenry
Copy link
Member

This schematic will be required in v12 because there is no TSLint to convert OOTB.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #426 (0820217) into master (2c7e466) will increase coverage by 1.91%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   64.14%   66.05%   +1.91%     
==========================================
  Files          14       15       +1     
  Lines         594      604      +10     
  Branches      118      120       +2     
==========================================
+ Hits          381      399      +18     
+ Misses        162      152      -10     
- Partials       51       53       +2     
Impacted Files Coverage Δ
packages/schematics/src/utils.ts 75.37% <47.05%> (+4.97%) ⬆️
...s/schematics/src/convert-tslint-to-eslint/index.ts 47.90% <50.00%> (+1.35%) ⬆️
...ages/schematics/src/add-eslint-to-project/index.ts 75.00% <75.00%> (ø)

@nx-cloud
Copy link

nx-cloud bot commented Apr 28, 2021

Nx Cloud Report

CI ran the following commands for commit 0820217. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

1 similar comment
@nx-cloud
Copy link

nx-cloud bot commented Apr 28, 2021

Nx Cloud Report

CI ran the following commands for commit 0820217. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@JamesHenry JamesHenry merged commit 7ae557d into master Apr 28, 2021
@JamesHenry JamesHenry deleted the add-eslint-to-project branch April 28, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant