feat(eslint-plugin-template): [accessibility-valid-aria] add suggestion #489
Conversation
Nx Cloud ReportCI ran the following commands for commit e8dbcb2. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
| @@ -47,7 +47,7 @@ ruleTester.run(RULE_NAME, rule, { | |||
| <div aria-roledescriptio="text">Text</div> | |||
There was a problem hiding this comment.
Hmm conceptually is the "fix" here really to remove what the user has written here?
Let's imagine this unit test is a real scenario, they clearly tried to add a real attribute and just made a typo. Then they run linting with --fix and instead of having chance to review their mistake and make their markup more accessible for users, they just have an unannotated div...
Maybe we have to go for suggestion only on this rule for that reason?
There was a problem hiding this comment.
I think you have a point. In this case, let's wait for #491 that offers the support for multiple suggestions in convertAnnotatedSourceToFailureCase.
There was a problem hiding this comment.
@JamesHenry I just noticed that in codelyzer#templateAccessibilityValidAriaRule.ts#L35 we suggest the closest aria attribute possible, instead of removing it, based on damerau-levenshtein.
So my question is: should we add this lib to mimic this behavior or is it fine as is?
rafaelss95
force-pushed
the
feat/accessibility-valid-aria-fixer
branch
from
e6f8091
to
e8dbcb2
Compare
rafaelss95
changed the title
No description provided.