feat(eslint-plugin): [use-component-view-encapsulation] add suggestion #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
force-pushed
the
feat/use-component-view-encapsulation-suggestion
branch
from
d1f613e
to
79cc65f
Compare
rafaelss95
commented
May 23, 2021
| @@ -362,6 +363,18 @@ export function getImplementsRemoveFix( | |||
| return []; | |||
| } | |||
|
|
|||
| export function getNodeToCommaRemoveFix( | |||
There was a problem hiding this comment.
I couldn't think of a better name, please suggest, if you want to.
rafaelss95
force-pushed
the
feat/use-component-view-encapsulation-suggestion
branch
from
79cc65f
to
6d5b28a
Compare
Nx Cloud ReportCI ran the following commands for commit b042726. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
rafaelss95
force-pushed
the
feat/use-component-view-encapsulation-suggestion
branch
from
6d5b28a
to
b176247
Compare
JamesHenry
requested changes
May 28, 2021
packages/eslint-plugin/src/rules/use-component-view-encapsulation.ts
Outdated
Show resolved
Hide resolved
rafaelss95
force-pushed
the
feat/use-component-view-encapsulation-suggestion
branch
from
d201e63
to
c229beb
Compare
rafaelss95
force-pushed
the
feat/use-component-view-encapsulation-suggestion
branch
from
c229beb
to
4418bdd
Compare
|
#518 has been merged |
rafaelss95
force-pushed
the
feat/use-component-view-encapsulation-suggestion
branch
from
77e3734
to
b042726
Compare
JamesHenry
approved these changes
Jun 12, 2021
|
Thanks @rafaelss95! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.