Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-template): [no-positive-tabindex] ignore custom elements #551

Merged
merged 2 commits into from Jun 19, 2021

Conversation

rafaelss95
Copy link
Member

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Jun 19, 2021

Nx Cloud Report

CI ran the following commands for commit a4785bd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Jun 19, 2021

Nx Cloud Report

CI ran the following commands for commit ada0903. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=build --all --parallel
#000000 nx run-many --target=check-configs --all --parallel
#000000 nx run-many --target=test --all --parallel
#000000 nx run-many --target=typecheck --all --parallel

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #551 (a4785bd) into master (0073815) will decrease coverage by 18.86%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #551       +/-   ##
===========================================
- Coverage   90.73%   71.86%   -18.87%     
===========================================
  Files          43       15       -28     
  Lines         971      654      -317     
  Branches      185      131       -54     
===========================================
- Hits          881      470      -411     
- Misses         57      120       +63     
- Partials       33       64       +31     
Impacted Files Coverage Δ
packages/schematics/src/ng-add/index.ts 74.50% <0.00%> (-13.96%) ⬇️
packages/schematics/src/utils.ts 78.16% <0.00%> (ø)
...matics/src/migrations/update-2-0-0/update-2-0-0.ts 96.77% <0.00%> (ø)
...s/schematics/src/convert-tslint-to-eslint/index.ts 50.29% <0.00%> (ø)
...matics/src/migrations/update-3-0-0/update-3-0-0.ts 90.00% <0.00%> (ø)
...es/schematics/src/migrations/utils/dependencies.ts 66.66% <0.00%> (ø)
packages/schematics/src/application/index.ts 100.00% <0.00%> (ø)
...matics/src/migrations/update-4-0-0/update-4-0-0.ts 93.33% <0.00%> (ø)
...tics/src/migrations/update-12-0-0/update-12-0-0.ts 97.61% <0.00%> (ø)
...nvert-tslint-to-eslint/convert-to-eslint-config.ts 50.00% <0.00%> (ø)
... and 5 more

@JamesHenry JamesHenry merged commit 5e33995 into angular-eslint:master Jun 19, 2021
@rafaelss95 rafaelss95 deleted the fix/no-positive-tabindex branch June 19, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants