New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [sort-ngmodule-metadata-arrays] remove the property restriction #694
fix(eslint-plugin): [sort-ngmodule-metadata-arrays] remove the property restriction #694
Conversation
Nx Cloud ReportCI ran the following commands for commit e5915c4. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, super clear thank you!
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
==========================================
- Coverage 85.38% 85.37% -0.01%
==========================================
Files 83 83
Lines 1923 1922 -1
Branches 339 339
==========================================
- Hits 1642 1641 -1
Misses 170 170
Partials 111 111
|
Commit 1 is from #693 and that PR should be merged first.
We currently have a restriction to search only some properties, but we don't need to. The rule should report all unordered arrays within
NgModule
, whatever the property name is.