Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [sort-ngmodule-metadata-arrays] remove the property restriction #694

Conversation

rafaelss95
Copy link
Member

Commit 1 is from #693 and that PR should be merged first.


We currently have a restriction to search only some properties, but we don't need to. The rule should report all unordered arrays within NgModule, whatever the property name is.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, super clear thank you!

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #694 (e5915c4) into master (886db08) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
- Coverage   85.38%   85.37%   -0.01%     
==========================================
  Files          83       83              
  Lines        1923     1922       -1     
  Branches      339      339              
==========================================
- Hits         1642     1641       -1     
  Misses        170      170              
  Partials      111      111              
Impacted Files Coverage Δ
...-plugin/src/rules/sort-ngmodule-metadata-arrays.ts 100.00% <100.00%> (ø)

@JamesHenry JamesHenry merged commit 440f6dc into angular-eslint:master Sep 20, 2021
@rafaelss95 rafaelss95 deleted the fix/sort-ngmodule-metadata-arrays-part-2 branch September 20, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants