Skip to content

Commit

Permalink
fix(grunt): update rev-ed images in css as well as js
Browse files Browse the repository at this point in the history
closes #977
  • Loading branch information
Awk34 committed Mar 10, 2016
1 parent bb045c5 commit 5a24b83
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions app/templates/Gruntfile(grunt).js
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ module.exports = function (grunt) {
],
// This is so we update image references in our ng-templates
patterns: {
css: [
[/(assets\/images\/.*?\.(?:gif|jpeg|jpg|png|webp|svg))/gm, 'Update the CSS to reference our revved images']
],
js: [
[/(assets\/images\/.*?\.(?:gif|jpeg|jpg|png|webp|svg))/gm, 'Update the JS to reference our revved images']
]
Expand Down

2 comments on commit 5a24b83

@riderx
Copy link

@riderx riderx commented on 5a24b83 Mar 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey it's cool you add the fix but why you don't but the font fix ?

@Awk34
Copy link
Member Author

@Awk34 Awk34 commented on 5a24b83 Mar 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't rev fonts anymore. They're not something that will really be changing, so there's not much point in adding a hash to the name

Please sign in to comment.