Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should client/app/admin and account be full components? #2490

Open
1 task done
nstuyvesant opened this issue Feb 4, 2017 · 1 comment
Open
1 task done

Should client/app/admin and account be full components? #2490

nstuyvesant opened this issue Feb 4, 2017 · 1 comment

Comments

@nstuyvesant
Copy link
Contributor

nstuyvesant commented Feb 4, 2017

  • I understand that GitHub issues are not for tech support, but for questions specific to this generator, bug reports, and feature requests.
Item Version
generator-angular-fullstack 4.1.2
Node 6.9.4
npm 4.1.2
Operating System OS X 10
Item Answer
Transpiler Babel
Markup Pug
CSS SCSS
Router ui-router
Client Tests Mocha
DB Sequelize 4.0.0-2 / PostgreSQL 9.6.1
Auth Y

account(auth) and admin(auth) are implemented as loosely coupled controllers. Their implementation differs from the generated main component (which is an AngularJS component). Also, possibly change their controllerAs to $ctrl from vm.

What are your thoughts about making admin, login, settings, and signup into full AngularJS components? This would improve consistency as well as lay the foundation for those moving to 2.0.

@Awk34
Copy link
Member

Awk34 commented Feb 4, 2017

It would probably be a good idea. I welcome any Pull Requests for such refactors.

The canary branch already has these as Angular 2.x.x components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants