Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): Add Passport support #25

Closed
nnance opened this issue Dec 1, 2013 · 9 comments
Closed

feat(rest): Add Passport support #25

nnance opened this issue Dec 1, 2013 · 9 comments

Comments

@nnance
Copy link

nnance commented Dec 1, 2013

I was thinking of creating a pull request to add Passport as an OAuth module for server side rest application. Of course I would make it optional. Is this valuable?

@snowman-repos
Copy link

👍

@jlmonteagudo
Copy link

Of course, it's valuable.

@DaftMonk
Copy link
Member

DaftMonk commented Dec 1, 2013

Yes, this would be a good a addition to the generator.

@kjellski
Copy link

@nnance are you going to do this? Otherwise, I'm going to build this now, it would be quite valuable for me and since this is my favorite generator, I would try to make it as good as I can... (I'm quite new to the whole node world though...)

@jarrettch
Copy link

@kjellski @nnance please do. I've been trying to fix my authentication in this generator for a whole day now.

@DaftMonk
Copy link
Member

If you want you can use this as a reference https://github.com/DaftMonk/angular-passport. I made it with an older version of the generator, but it might help you get started.

@nnance
Copy link
Author

nnance commented Dec 13, 2013

@kjellski I am actively working on this. It is coming slower than I expected. I hope to have i working in the next few days. @DaftMonk thanks for the reference. It might help me resolve a couple of outstanding issues.

@kjellski
Copy link

@nnance I'm unable to find any repos from your side on github where I could contribute, but I'm willing to hack away and throw it out of the window if it won't fit in. Here are my thoughts:

  • User model with password encryption by bcrypt.
  • Authentication middleware straight from passport.

is there interest in having a default "web side" for this?

otherwise I would just "steal" from mean.io

@kjellski
Copy link

I've opened a pull request #36 that has the serverside basically done. Any feedback is appreciated.

EDIT: I've made my way through the server side on this, client side needs feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants