Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TRANSLATION_ID provided as element attribute #64

Closed
dhiraj opened this issue Oct 30, 2015 · 4 comments
Closed

Support TRANSLATION_ID provided as element attribute #64

dhiraj opened this issue Oct 30, 2015 · 4 comments

Comments

@dhiraj
Copy link

dhiraj commented Oct 30, 2015

When translation IDs are supplied in markup in the form:

<ANY translate="TRANSLATION_ID">Default translation</ANY>

The translation files are generated like this:

"Default translation":"Default translation"

Instead of:

"TRANSLATION_ID":"Default translation"

Can support be added for this?

@alexrada
Copy link

I'm having a similar issue here, couldn't find a fix for it.

@firehist
Copy link
Member

@alexrada I updated the code, can you take a look @ #68 ?

@alexrada
Copy link

There will be an error on line 70 if r has length == 2
Same on line 74

if (r.length >= 2) {
...
translationDefaultValue = r[2].trim();

So if r has only 2 elements this will output an error.

@firehist
Copy link
Member

Yes thanks!
And an other one, I removed the simple translate usage :D => Fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants