Use this.sourceInfo.cloneModel instead

[nicklasb]

Instead of again copying the original model value, use the already copied cloneModel that is exposed in the drag events.
This way, users can intercept and change the cloned data.

[nicklasb]

See #628

[doillee]

I need this fix too. I made the same fix in my local copy, however, it would be great if it can be part of official release.

[Voles]

this.sourceInfo.cloneModel seems like the right solution. However, in cloneModel() (L127), we check if cloning is enabled, as well as here (L172). This means we perform the check 2 times (in helper.js on L127 and here on L172).

Do you have any suggestions on how we can refactor this to prevent double checking?

[nicklasb]

No..we check isClone, not cloneEnabled, right? Isn't it rather the comment that is wrong?
I'd say that is another commit.

[Voles]

See my feedback. Can you add a unit-test for this behaviour?

[Voles]

Any updates on this, @nicklasb? I'm not sure it's easy to add tests for this with the current codebase, but it would be nice to get your feedback on my comment. Thanks again!

[nicklasb]

Hi, strange, I haven't seen any updates for this issue until now.
WRT unit test, I am not sure that I know how I would do that nicely.
And the test would only check that this fix is still applied.
Rather, it seems like the entire drag'n drop behavior should be tested, but that feels like a larger thing.

[Voles]

@nicklasb would it be possible to create a jsFiddle to reproduce the issue / effect. I'm not really sure what you try to achieve with the fix. Or maybe @doillee can provide additional information on his use case?

[nicklasb]

Well, probably, but this is a very pretty reasonable and simple change.
I am not sure I have gotten through with my explanation, so I'll try again:

Currently, the original value, not cloneModel, is inserted into the target, which means that any changes to the cloneModel are disregarded and thus there is no way to intercept and affect what data is inserted into the target tree. The only thing you can insert is exactly the original.
This just cannot be correct in any circumstance? There is not much point in cloning the first time, then.

[Voles]

I got your point, thanks for explaining again. It would be helpful to add this to the documentation for future reference. Thanks!